Commit 4c06d35d authored by Shyam Sundar S K's avatar Shyam Sundar S K Committed by Hans de Goede
Browse files

platform/x86: amd-pmc: Fix SMU firmware reporting mechanism 



It was lately understood that the current mechanism available in the
driver to get SMU firmware info works only on internal SMU builds and
there is a separate way to get all the SMU logging counters (addressed
in the next patch). Hence remove all the smu info shown via debugfs as it
is no more useful.

Fixes: 156ec473 ("platform/x86: amd-pmc: Add AMD platform support for S2Idle")
Signed-off-by: default avatarShyam Sundar S K <Shyam-sundar.S-k@amd.com>
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20210629084803.248498-3-Shyam-sundar.S-k@amd.com


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 95e1b60f

drivers/platform/x86/amd-pmc.c

+0 −10
Original line number Diff line number Diff line
@@ -52,7 +52,6 @@ 
#define AMD_CPU_ID_PCO			AMD_CPU_ID_RV

#define AMD_CPU_ID_CZN			AMD_CPU_ID_RN



#define AMD_SMU_FW_VERSION		0x0

#define PMC_MSG_DELAY_MIN_US		100

#define RESPONSE_REGISTER_LOOP_MAX	200
@@ -89,11 +88,6 @@ static inline void amd_pmc_reg_write(struct amd_pmc_dev *dev, int reg_offset, u3 
#ifdef CONFIG_DEBUG_FS

static int smu_fw_info_show(struct seq_file *s, void *unused)

{

	struct amd_pmc_dev *dev = s->private;

	u32 value;



	value = ioread32(dev->smu_base + AMD_SMU_FW_VERSION);

	seq_printf(s, "SMU FW Info: %x\n", value);

	return 0;

}

DEFINE_SHOW_ATTRIBUTE(smu_fw_info);
@@ -280,10 +274,6 @@ static int amd_pmc_probe(struct platform_device *pdev) 
	pci_dev_put(rdev);

	base_addr = ((u64)base_addr_hi << 32 | base_addr_lo);



	dev->smu_base = devm_ioremap(dev->dev, base_addr, AMD_PMC_MAPPING_SIZE);

	if (!dev->smu_base)

		return -ENOMEM;



	dev->regbase = devm_ioremap(dev->dev, base_addr + AMD_PMC_BASE_ADDR_OFFSET,

				    AMD_PMC_MAPPING_SIZE);

	if (!dev->regbase)