Commit 147178cf authored by Sergey Shtylyov's avatar Sergey Shtylyov Committed by Wolfram Sang
Browse files

i2c: rcar: add IRQ check 



The driver neglects to check the result of platform_get_irq()'s call and
blithely passes the negative error codes to devm_request_irq() (which
takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding
an original error code.  Stop calling devm_request_irq() with the
invalid IRQ #s.

Fixes: 6ccbe607 ("i2c: add Renesas R-Car I2C driver")
Signed-off-by: default avatarSergey Shtylyov <s.shtylyov@omprussia.ru>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent 0d3bf53e

drivers/i2c/busses/i2c-rcar.c

+4 −1
Original line number Diff line number Diff line
@@ -1099,7 +1099,10 @@ static int rcar_i2c_probe(struct platform_device *pdev) 
	if (of_property_read_bool(dev->of_node, "smbus"))

		priv->flags |= ID_P_HOST_NOTIFY;



	priv->irq = platform_get_irq(pdev, 0);

	ret = platform_get_irq(pdev, 0);

	if (ret < 0)

		goto out_pm_disable;

	priv->irq = ret;

	ret = devm_request_irq(dev, priv->irq, irqhandler, irqflags, dev_name(dev), priv);

	if (ret < 0) {

		dev_err(dev, "cannot get irq %d\n", priv->irq);