Commit 132023de authored by Jian Shen's avatar Jian Shen Committed by Jakub Kicinski
Browse files

net: hns3: remove unnecessary updating port based VLAN 



For the PF have called hclge_update_port_base_vlan_cfg() already
before notify VF, it's unnecessary to update port based VLAN again
when received mailbox request from VF.

Signed-off-by: default avatarJian Shen <shenjian15@huawei.com>
Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent f2dbf0ed

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c

+0 −9
Original line number Diff line number Diff line
@@ -360,15 +360,6 @@ static int hclge_set_vf_vlan_cfg(struct hclge_vport *vport, 
		bool en = msg_cmd->is_kill ? true : false;



		status = hclge_en_hw_strip_rxvtag(handle, en);

	} else if (msg_cmd->subcode == HCLGE_MBX_PORT_BASE_VLAN_CFG) {

		struct hclge_vlan_info *vlan_info;

		u16 *state;



		state = (u16 *)&mbx_req->msg.data[HCLGE_MBX_VLAN_STATE_OFFSET];

		vlan_info = (struct hclge_vlan_info *)

			&mbx_req->msg.data[HCLGE_MBX_VLAN_INFO_OFFSET];

		status = hclge_update_port_base_vlan_cfg(vport, *state,

							 vlan_info);

	} else if (msg_cmd->subcode == HCLGE_MBX_GET_PORT_BASE_VLAN_STATE) {

		struct hnae3_ae_dev *ae_dev = pci_get_drvdata(vport->nic.pdev);

		/* vf does not need to know about the port based VLAN state