Commit 121f31f3 authored by Martin KaFai Lau's avatar Martin KaFai Lau Committed by Alexei Starovoitov
Browse files

bpf: Remove the preceding __ from __bpf_selem_unlink_storage 



__bpf_selem_unlink_storage is taking the spin lock and there is
no name collision also. Having the preceding '__' is confusing
when reviewing the later patch.

Signed-off-by: default avatarMartin KaFai Lau <martin.lau@kernel.org>
Link: https://lore.kernel.org/r/20230308065936.1550103-5-martin.lau@linux.dev


Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
parent 62827d61

kernel/bpf/bpf_local_storage.c

+3 −3
Original line number Diff line number Diff line
@@ -216,7 +216,7 @@ static bool bpf_selem_unlink_storage_nolock(struct bpf_local_storage *local_stor 
	return free_local_storage;

}



static void __bpf_selem_unlink_storage(struct bpf_local_storage_elem *selem,

static void bpf_selem_unlink_storage(struct bpf_local_storage_elem *selem,

				     bool use_trace_rcu)

{

	struct bpf_local_storage *local_storage;
@@ -288,7 +288,7 @@ void bpf_selem_unlink(struct bpf_local_storage_elem *selem, bool use_trace_rcu) 
	 * the local_storage.

	 */

	bpf_selem_unlink_map(selem);

	__bpf_selem_unlink_storage(selem, use_trace_rcu);

	bpf_selem_unlink_storage(selem, use_trace_rcu);

}



/* If cacheit_lockit is false, this lookup function is lockless */