Unverified Commit 10f48a12 authored Jan 13, 2021 by Mark Brown

Merge series "spi: cadence-quadspi: Add QSPI controller support for Intel LGM...

Merge series "spi: cadence-quadspi: Add QSPI controller support for Intel LGM SoC" from "Ramuthevar, Vadivel MuruganX" <vadivel.muruganx.ramuthevar@linux.intel.com>:

Add QSPI controller support for Intel LGM SoC.

Patches to move move bindings over to
"Documentation/devicetree/bindings/spi/" directory and also added compatible
Support for Intel platform.

dt-bindings: spi: cadence-qspi: Add support for Intel lgm-qspi
(earlier patch mail thread and Ack-by)
link: "https://lore.kernel.org/lkml/5d6d1b85.1c69fb81.96938.0315@mx.google.com/"

Reference:
        https://lkml.org/lkml/2020/6/1/50
---
v9:
  - Vignesh review comments address and update
  - Retain the patchv4 move the binding documentation from mtd to spi
    directory.
  - Add intel's compatible string over the legacy documentation
  - Remove unused variable, CQSPI_SUPPORTS_MULTI_CHIPSELECT macro and check
  - YAML convertion patch alone dropped
v8:
  - As Mark suggested to add the dt-bindings documentation patches
    end of the series , so dropped.
v7:
  - Rob's review comments address and fixed dt-schema warning
  - Pratyush review comments address and update
  - DAC bit reset to 0 and 1 (enable/disable)
  - tested QSI-NOR flash mx25l12805d on LGM soc, it's working after disable DAC
  - Linus suggested to use 'num-cs' prperty instead of 'num-chipselect'
v6:
  - Rob's review comments update
  - add compatible string in properly aligned
  - remove cadence-qspi extra comaptible string in example
v5:
  - Rob's review comments update
  - const with single compatible string kept
v4:
  - Rob's review comments update
  - remove '|' no formatting to preserve
  - child node attributes follows under 'properties' under '@[0-9a-f]+$'.
v3:
  - Pratyush review comments update
  - CQSPI_SUPPORTS_MULTI_CHIPSELECT macro used instead of cqspi->use_direct_mode
  - disable DAC support placed in end of controller_init
v2:
  - Rob's review comments update for dt-bindings
  - add 'oneOf' for compatible selection
  - drop un-neccessary descriptions
  - add the cdns,is-decoded-cs and cdns,rclk-en properties as schema
  - remove 'allOf' in not required place
  - add AdditionalProperties false
  - add minItems/maxItems for qspi reset attributes

resend-v1:
  - As per Mark's suggestion , reorder the patch series 1-3 driver
    support patches, series 4-6 dt-bindings patches.
v1:
  - initial version

Ramuthevar Vadivel Murugan (5):
  spi: cadence-quadspi: Add QSPI support for Intel LGM SoC
  spi: cadence-quadspi: Disable the DAC for Intel LGM SoC
  spi: cadence-quadspi: Add multi-chipselect support for Intel LGM SoC
  spi: Move cadence-quadspi.txt to Documentation/devicetree/bindings/spi
  dt-bindings: spi: cadence-qspi: Add support for Intel lgm-qspi

 .../bindings/{mtd => spi}/cadence-quadspi.txt      |  1 +
 drivers/spi/Kconfig                                |  2 +-
 drivers/spi/spi-cadence-quadspi.c                  | 24 ++++++++++++++++++----
 3 files changed, 22 insertions(+), 5 deletions(-)
 rename Documentation/devicetree/bindings/{mtd => spi}/cadence-quadspi.txt (97%)

--
2.11.0

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

parents 970e8eaa fcebca39

Documentation/devicetree/bindings/mtd/cadence-quadspi.txt→Documentation/devicetree/bindings/spi/cadence-quadspi.txt

+1 −0

Original line number	Diff line number	Diff line
		@@ -5,6 +5,7 @@ Required properties:
		Generic default - "cdns,qspi-nor".
		For TI 66AK2G SoC - "ti,k2g-qspi", "cdns,qspi-nor".
		For TI AM654 SoC - "ti,am654-ospi", "cdns,qspi-nor".
		For Intel LGM SoC - "intel,lgm-qspi", "cdns,qspi-nor".
		- reg : Contains two entries, each of which is a tuple consisting of a
		physical address and length. The first entry is the address and
		length of the controller register set. The second entry is the

drivers/spi/Kconfig

+1 −1

Original line number	Diff line number	Diff line
		@@ -203,7 +203,7 @@ config SPI_CADENCE

		config SPI_CADENCE_QUADSPI
		tristate "Cadence Quad SPI controller"
		depends on OF && (ARM \|\| ARM64 \|\| COMPILE_TEST)
		depends on OF && (ARM \|\| ARM64 \|\| X86 \|\| COMPILE_TEST)
		help
		Enable support for the Cadence Quad SPI Flash controller.

drivers/spi/spi-cadence-quadspi.c

+20 −4

Original line number	Diff line number	Diff line
		@@ -76,6 +76,7 @@ struct cqspi_st {
		bool is_decoded_cs;
		u32 fifo_depth;
		u32 fifo_width;
		u32 num_chipselect;
		bool rclk_en;
		u32 trigger_address;
		u32 wr_delay;
		@@ -1353,6 +1354,9 @@ static int cqspi_of_get_pdata(struct cqspi_st *cqspi)
		return -ENXIO;
		}

		if (of_property_read_u32(np, "num-cs", &cqspi->num_chipselect))
		cqspi->num_chipselect = CQSPI_MAX_CHIPSELECT;

		cqspi->rclk_en = of_property_read_bool(np, "cdns,rclk-en");

		return 0;
		@@ -1384,10 +1388,12 @@ static void cqspi_controller_init(struct cqspi_st *cqspi)
		writel(cqspi->fifo_depth * cqspi->fifo_width / 8,
		cqspi->iobase + CQSPI_REG_INDIRECTWRWATERMARK);

		/* Enable Direct Access Controller */
		/* Disable direct access controller */
		if (!cqspi->use_direct_mode) {
		reg = readl(cqspi->iobase + CQSPI_REG_CONFIG);
		reg \|= CQSPI_REG_CONFIG_ENB_DIR_ACC_CTRL;
		reg &= ~CQSPI_REG_CONFIG_ENB_DIR_ACC_CTRL;
		writel(reg, cqspi->iobase + CQSPI_REG_CONFIG);
		}

		cqspi_controller_enable(cqspi, 1);
		}
		@@ -1587,6 +1593,8 @@ static int cqspi_probe(struct platform_device *pdev)
		cqspi->current_cs = -1;
		cqspi->sclk = 0;

		master->num_chipselect = cqspi->num_chipselect;

		ret = cqspi_setup_flash(cqspi);
		if (ret) {
		dev_err(dev, "failed to setup flash parameters %d\n", ret);
		@@ -1675,6 +1683,10 @@ static const struct cqspi_driver_platdata am654_ospi = {
		.quirks = CQSPI_NEEDS_WR_DELAY,
		};

		static const struct cqspi_driver_platdata intel_lgm_qspi = {
		.quirks = CQSPI_DISABLE_DAC_MODE,
		};

		static const struct of_device_id cqspi_dt_ids[] = {
		{
		.compatible = "cdns,qspi-nor",
		@@ -1688,6 +1700,10 @@ static const struct of_device_id cqspi_dt_ids[] = {
		.compatible = "ti,am654-ospi",
		.data = &am654_ospi,
		},
		{
		.compatible = "intel,lgm-qspi",
		.data = &intel_lgm_qspi,
		},
		{ /* end of table */ }
		};