Commit 1026f7d3 authored by Andrew Halaney's avatar Andrew Halaney Committed by Martin K. Petersen
Browse files

scsi: ufs: ufs-qcom: Use dev_err() where possible 



dev_err() statements are better to use than pr_err(), so switch to those.

In a similar vein, the check on the dev_req_params pointer here is not
needed, the two places this function is called never pass in a NULL
pointer, so instead of using dev_err() there just remove it.

Signed-off-by: default avatarAndrew Halaney <ahalaney@redhat.com>
Reviewed-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: default avatarAsutosh Das <quic_asutoshd@quicinc.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent e4ce23fb

drivers/ufs/host/ufs-qcom.c

+1 −7
Original line number Diff line number Diff line
@@ -680,12 +680,6 @@ static int ufs_qcom_pwr_change_notify(struct ufs_hba *hba, 
	struct ufs_dev_params ufs_qcom_cap;

	int ret = 0;



	if (!dev_req_params) {

		pr_err("%s: incoming dev_req_params is NULL\n", __func__);

		ret = -EINVAL;

		goto out;

	}



	switch (status) {

	case PRE_CHANGE:

		ufshcd_init_pwr_dev_param(&ufs_qcom_cap);
@@ -709,7 +703,7 @@ static int ufs_qcom_pwr_change_notify(struct ufs_hba *hba, 
					       dev_max_params,

					       dev_req_params);

		if (ret) {

			pr_err("%s: failed to determine capabilities\n",

			dev_err(hba->dev, "%s: failed to determine capabilities\n",

					__func__);

			goto out;

		}