Commit e4ce23fb authored by Andrew Halaney's avatar Andrew Halaney Committed by Martin K. Petersen
Browse files

scsi: ufs: ufs-qcom: Remove usage of dbg_print_en 



This bitmask is unconditionally set in the current driver, so all
conditionals using it can be considered bit rot.

Let's take the current default conditional path everywhere and remove
dbg_print_en from the driver.

Signed-off-by: default avatarAndrew Halaney <ahalaney@redhat.com>
Reviewed-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: default avatarAsutosh Das <quic_asutoshd@quicinc.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 50a427a0

drivers/ufs/host/ufs-qcom.c

+3 −15
Original line number Diff line number Diff line
@@ -22,9 +22,6 @@ 
#include <ufs/ufshci.h>

#include <ufs/ufs_quirks.h>



#define UFS_QCOM_DEFAULT_DBG_PRINT_EN	\

	(UFS_QCOM_DBG_PRINT_REGS_EN | UFS_QCOM_DBG_PRINT_TEST_BUS_EN)



enum {

	TSTBUS_UAWM,

	TSTBUS_UARM,
@@ -1040,7 +1037,6 @@ static int ufs_qcom_init(struct ufs_hba *hba) 
	if (hba->dev->id < MAX_UFS_QCOM_HOSTS)

		ufs_qcom_hosts[hba->dev->id] = host;



	host->dbg_print_en |= UFS_QCOM_DEFAULT_DBG_PRINT_EN;

	ufs_qcom_get_default_testbus_cfg(host);

	err = ufs_qcom_testbus_config(host);

	if (err) {
@@ -1191,14 +1187,9 @@ static int ufs_qcom_clk_scale_notify(struct ufs_hba *hba, 


static void ufs_qcom_enable_test_bus(struct ufs_qcom_host *host)

{

	if (host->dbg_print_en & UFS_QCOM_DBG_PRINT_TEST_BUS_EN) {

	ufshcd_rmwl(host->hba, UFS_REG_TEST_BUS_EN,

			UFS_REG_TEST_BUS_EN, REG_UFS_CFG1);

	ufshcd_rmwl(host->hba, TEST_BUS_EN, TEST_BUS_EN, REG_UFS_CFG1);

	} else {

		ufshcd_rmwl(host->hba, UFS_REG_TEST_BUS_EN, 0, REG_UFS_CFG1);

		ufshcd_rmwl(host->hba, TEST_BUS_EN, 0, REG_UFS_CFG1);

	}

}



static void ufs_qcom_get_default_testbus_cfg(struct ufs_qcom_host *host)
@@ -1315,9 +1306,6 @@ static void ufs_qcom_dump_dbg_regs(struct ufs_hba *hba) 
	ufshcd_dump_regs(hba, REG_UFS_SYS1CLK_1US, 16 * 4,

			 "HCI Vendor Specific Registers ");



	if (!(host->dbg_print_en & UFS_QCOM_DBG_PRINT_REGS_EN))

		return;



	reg = ufs_qcom_get_debug_reg_offset(host, UFS_UFS_DBG_RD_REG_OCSC);

	ufshcd_dump_regs(hba, reg, 44 * 4, "UFS_UFS_DBG_RD_REG_OCSC ");

drivers/ufs/host/ufs-qcom.h

+0 −11
Original line number Diff line number Diff line
@@ -113,15 +113,6 @@ enum { 
	MASK_CLK_NS_REG                     = 0xFFFC00,

};



/* QCOM UFS debug print bit mask */

#define UFS_QCOM_DBG_PRINT_REGS_EN	BIT(0)

#define UFS_QCOM_DBG_PRINT_ICE_REGS_EN	BIT(1)

#define UFS_QCOM_DBG_PRINT_TEST_BUS_EN	BIT(2)



#define UFS_QCOM_DBG_PRINT_ALL	\

	(UFS_QCOM_DBG_PRINT_REGS_EN | UFS_QCOM_DBG_PRINT_ICE_REGS_EN | \

	 UFS_QCOM_DBG_PRINT_TEST_BUS_EN)



/* QUniPro Vendor specific attributes */

#define PA_VS_CONFIG_REG1	0x9000

#define DME_VS_CORE_CLK_CTRL	0xD002
@@ -212,8 +203,6 @@ struct ufs_qcom_host { 


	u32 dev_ref_clk_en_mask;



	/* Bitmask for enabling debug prints */

	u32 dbg_print_en;

	struct ufs_qcom_testbus testbus;



	/* Reset control of HCI */