Commit 0f4b20ef authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Greg Kroah-Hartman
Browse files

slimbus: qcom-ngd: Fix kfree() of static memory on setting driver_override 



The driver_override field from platform driver should not be initialized
from static memory (string literal) because the core later kfree() it,
for example when driver_override is set via sysfs.

Use dedicated helper to set driver_override properly.

Fixes: 917809e2 ("slimbus: ngd: Add qcom SLIMBus NGD driver")
Reviewed-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20220419113435.246203-11-krzysztof.kozlowski@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fb4ac6f1

drivers/slimbus/qcom-ngd-ctrl.c

+12 −1
Original line number Diff line number Diff line
@@ -1434,6 +1434,7 @@ static int of_qcom_slim_ngd_register(struct device *parent, 
	const struct of_device_id *match;

	struct device_node *node;

	u32 id;

	int ret;



	match = of_match_node(qcom_slim_ngd_dt_match, parent->of_node);

	data = match->data;
@@ -1455,7 +1456,17 @@ static int of_qcom_slim_ngd_register(struct device *parent, 
		}

		ngd->id = id;

		ngd->pdev->dev.parent = parent;

		ngd->pdev->driver_override = QCOM_SLIM_NGD_DRV_NAME;



		ret = driver_set_override(&ngd->pdev->dev,

					  &ngd->pdev->driver_override,

					  QCOM_SLIM_NGD_DRV_NAME,

					  strlen(QCOM_SLIM_NGD_DRV_NAME));

		if (ret) {

			platform_device_put(ngd->pdev);

			kfree(ngd);

			of_node_put(node);

			return ret;

		}

		ngd->pdev->dev.of_node = node;

		ctrl->ngd = ngd;