Commit fb4ac6f1 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Greg Kroah-Hartman
Browse files

clk: imx: scu: Fix kfree() of static memory on setting driver_override 



The driver_override field from platform driver should not be initialized
from static memory (string literal) because the core later kfree() it,
for example when driver_override is set via sysfs.

Use dedicated helper to set driver_override properly.

Fixes: 77d8f306 ("clk: imx: scu: add two cells binding support")
Acked-by: default avatarStephen Boyd <sboyd@kernel.org>
Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20220419113435.246203-10-krzysztof.kozlowski@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 240bf4e6

drivers/clk/imx/clk-scu.c

+6 −1
Original line number Diff line number Diff line
@@ -683,7 +683,12 @@ struct clk_hw *imx_clk_scu_alloc_dev(const char *name, 
		return ERR_PTR(ret);

	}



	pdev->driver_override = "imx-scu-clk";

	ret = driver_set_override(&pdev->dev, &pdev->driver_override,

				  "imx-scu-clk", strlen("imx-scu-clk"));

	if (ret) {

		platform_device_put(pdev);

		return ERR_PTR(ret);

	}



	ret = imx_clk_scu_attach_pd(&pdev->dev, rsrc_id);

	if (ret)