Commit 0f45e75e authored by Nicholas Graumann's avatar Nicholas Graumann Committed by Vinod Koul
Browse files

dmaengine: xilinx_dma: Merge get_callback and _invoke 



The dma api provides a single interface to get the appropriate callback
and invoke it directly. Prefer using it.

Signed-off-by: default avatarNicholas Graumann <nick.graumann@gmail.com>
Signed-off-by: default avatarRadhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Link: https://lore.kernel.org/r/1571150904-3988-3-git-send-email-radhey.shyam.pandey@xilinx.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 005a0179

drivers/dma/xilinx/xilinx_dma.c

+1 −4
Original line number Diff line number Diff line
@@ -820,8 +820,6 @@ static void xilinx_dma_chan_desc_cleanup(struct xilinx_dma_chan *chan) 
	spin_lock_irqsave(&chan->lock, flags);



	list_for_each_entry_safe(desc, next, &chan->done_list, node) {

		struct dmaengine_desc_callback cb;



		if (desc->cyclic) {

			xilinx_dma_chan_handle_cyclic(chan, desc, &flags);

			break;
@@ -831,9 +829,8 @@ static void xilinx_dma_chan_desc_cleanup(struct xilinx_dma_chan *chan) 
		list_del(&desc->node);



		/* Run the link descriptor callback function */

		dmaengine_desc_get_callback(&desc->async_tx, &cb);

		spin_unlock_irqrestore(&chan->lock, flags);

		dmaengine_desc_callback_invoke(&cb, NULL);

		dmaengine_desc_get_callback_invoke(&desc->async_tx, NULL);

		spin_lock_irqsave(&chan->lock, flags);



		/* Run any dependencies, then free the descriptor */