Commit 005a0179 authored by Radhey Shyam Pandey's avatar Radhey Shyam Pandey Committed by Vinod Koul
Browse files

dmaengine: xilinx_dma: Remove desc_callback_valid check 



In descriptor cleanup the call to desc_callback_valid can be safely
removed as both callback pointers i.e callback_result and callback
are anyway checked in invoke(). There is no much benefit in having
redundant checks.

Signed-off-by: default avatarRadhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Signed-off-by: default avatarNicholas Graumann <nick.graumann@gmail.com>
Reviewed-by: default avatarAppana Durga Kedareswara rao <appana.durga.rao@xilinx.com>
Link: https://lore.kernel.org/r/1571150904-3988-2-git-send-email-radhey.shyam.pandey@xilinx.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent a6e9be05

drivers/dma/xilinx/xilinx_dma.c

+3 −5
Original line number Diff line number Diff line
@@ -832,11 +832,9 @@ static void xilinx_dma_chan_desc_cleanup(struct xilinx_dma_chan *chan) 


		/* Run the link descriptor callback function */

		dmaengine_desc_get_callback(&desc->async_tx, &cb);

		if (dmaengine_desc_callback_valid(&cb)) {

		spin_unlock_irqrestore(&chan->lock, flags);

		dmaengine_desc_callback_invoke(&cb, NULL);

		spin_lock_irqsave(&chan->lock, flags);

		}



		/* Run any dependencies, then free the descriptor */

		dma_run_dependencies(&desc->async_tx);