Commit 0e069265 authored by Lino Sanfilippo's avatar Lino Sanfilippo Committed by Jarkko Sakkinen
Browse files

tpm, tpm_tis: Claim locality in interrupt handler 



Writing the TPM_INT_STATUS register in the interrupt handler to clear the
interrupts only has effect if a locality is held. Since this is not
guaranteed at the time the interrupt is fired, claim the locality
explicitly in the handler.

Signed-off-by: default avatarLino Sanfilippo <l.sanfilippo@kunbus.com>
Tested-by: default avatarMichael Niewöhner <linux@mniewoehner.de>
Tested-by: default avatarJarkko Sakkinen <jarkko@kernel.org>
Reviewed-by: default avatarJarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: default avatarJarkko Sakkinen <jarkko@kernel.org>
parent 0c7e66e5

drivers/char/tpm/tpm_tis_core.c

+2 −0
Original line number Diff line number Diff line
@@ -776,7 +776,9 @@ static irqreturn_t tis_int_handler(int dummy, void *dev_id) 
		wake_up_interruptible(&priv->int_queue);



	/* Clear interrupts handled with TPM_EOI */

	tpm_tis_request_locality(chip, 0);

	rc = tpm_tis_write32(priv, TPM_INT_STATUS(priv->locality), interrupt);

	tpm_tis_relinquish_locality(chip, 0);

	if (rc < 0)

		return IRQ_NONE;