Commit 0c7e66e5 authored by Lino Sanfilippo's avatar Lino Sanfilippo Committed by Jarkko Sakkinen
Browse files

tpm, tpm_tis: Request threaded interrupt handler 



The TIS interrupt handler at least has to read and write the interrupt
status register. In case of SPI both operations result in a call to
tpm_tis_spi_transfer() which uses the bus_lock_mutex of the spi device
and thus must only be called from a sleepable context.

To ensure this request a threaded interrupt handler.

Signed-off-by: default avatarLino Sanfilippo <l.sanfilippo@kunbus.com>
Tested-by: default avatarMichael Niewöhner <linux@mniewoehner.de>
Tested-by: default avatarJarkko Sakkinen <jarkko@kernel.org>
Reviewed-by: default avatarJarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: default avatarJarkko Sakkinen <jarkko@kernel.org>
parent 7a2f55d0

drivers/char/tpm/tpm_tis_core.c

+5 −2
Original line number Diff line number Diff line
@@ -809,8 +809,11 @@ static int tpm_tis_probe_irq_single(struct tpm_chip *chip, u32 intmask, 
	int rc;

	u32 int_status;



	if (devm_request_irq(chip->dev.parent, irq, tis_int_handler, flags,

			     dev_name(&chip->dev), chip) != 0) {



	rc = devm_request_threaded_irq(chip->dev.parent, irq, NULL,

				       tis_int_handler, IRQF_ONESHOT | flags,

				       dev_name(&chip->dev), chip);

	if (rc) {

		dev_info(&chip->dev, "Unable to request irq: %d for probe\n",

			 irq);

		return -1;