Commit 0c6ca807 authored by Martin Faltesek's avatar Martin Faltesek Committed by sanglipeng
Browse files

nfc: st-nci: fix incorrect validating logic in EVT_TRANSACTION

stable inclusion
from stable-v5.10.157
commit e14583073fc0f31b35b7de4eefbb1e2720914e0f
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I7MU59

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=e14583073fc0f31b35b7de4eefbb1e2720914e0f



--------------------------------

[ Upstream commit c60c1522 ]

The first validation check for EVT_TRANSACTION has two different checks
tied together with logical AND. One is a check for minimum packet length,
and the other is for a valid aid_tag. If either condition is true (fails),
then an error should be triggered. The fix is to change && to ||.

Reported-by: default avatarDenis Efremov <denis.e.efremov@oracle.com>
Reviewed-by: default avatarGuenter Roeck <groeck@google.com>
Fixes: 5d1ceb7f ("NFC: st21nfcb: Add HCI transaction event support")
Signed-off-by: default avatarMartin Faltesek <mfaltesek@google.com>
Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarsanglipeng <sanglipeng1@jd.com>
parent 612ac896
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment