Commit 0a6ea04e authored by Tony Nguyen's avatar Tony Nguyen Committed by Jeff Kirsher
Browse files

ice: Remove possible null dereference 



Commit 1f45ebe0 ("ice: add extra check for null Rx descriptor") moved
the call to ice_construct_skb() under a null check as Coverity reported a
possible use of null skb. However, the original call was not deleted, do so
now.

Fixes: 1f45ebe0 ("ice: add extra check for null Rx descriptor")
Reported-by: default avatarBruce Allan <bruce.w.allan@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent cf8fc2a0

drivers/net/ethernet/intel/ice/ice_txrx.c

+0 −2
Original line number Diff line number Diff line
@@ -1078,8 +1078,6 @@ static int ice_clean_rx_irq(struct ice_ring *rx_ring, int budget) 
				skb = ice_build_skb(rx_ring, rx_buf, &xdp);

			else

				skb = ice_construct_skb(rx_ring, rx_buf, &xdp);

		} else {

			skb = ice_construct_skb(rx_ring, rx_buf, &xdp);

		}

		/* exit if we failed to retrieve a buffer */

		if (!skb) {