Commit 0866200e authored by Sagi Grimberg's avatar Sagi Grimberg Committed by Christoph Hellwig
Browse files

nvme: Have NVME_FABRICS select NVME_CORE instead of transport drivers 



Transport drivers need both core and fabrics modules, instead of
selecting both, have the selection transitive such that NVME_FABRICS
selects NVME_CORE and transport drivers select NVME_FABRICS.

Suggested-by: default avatarKeith Busch <kbusch@kernel.org>
Signed-off-by: default avatarSagi Grimberg <sagi@grimberg.me>
Reviewed-by: default avatarChaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Reviewed-by: default avatarJames Smart <jsmart2021@gmail.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent e19e9f47

drivers/nvme/host/Kconfig

+1 −3
Original line number Diff line number Diff line
@@ -33,12 +33,12 @@ config NVME_HWMON 
	  in the system.



config NVME_FABRICS

	select NVME_CORE

	tristate



config NVME_RDMA

	tristate "NVM Express over Fabrics RDMA host driver"

	depends on INFINIBAND && INFINIBAND_ADDR_TRANS && BLOCK

	select NVME_CORE

	select NVME_FABRICS

	select SG_POOL

	help
@@ -55,7 +55,6 @@ config NVME_FC 
	tristate "NVM Express over Fabrics FC host driver"

	depends on BLOCK

	depends on HAS_DMA

	select NVME_CORE

	select NVME_FABRICS

	select SG_POOL

	help
@@ -72,7 +71,6 @@ config NVME_TCP 
	tristate "NVM Express over Fabrics TCP host driver"

	depends on INET

	depends on BLOCK

	select NVME_CORE

	select NVME_FABRICS

	select CRYPTO

	select CRYPTO_CRC32C

drivers/nvme/target/Kconfig

+0 −2
Original line number Diff line number Diff line
@@ -31,7 +31,6 @@ config NVME_TARGET_PASSTHRU 
config NVME_TARGET_LOOP

	tristate "NVMe loopback device support"

	depends on NVME_TARGET

	select NVME_CORE

	select NVME_FABRICS

	select SG_POOL

	help
@@ -65,7 +64,6 @@ config NVME_TARGET_FC 
config NVME_TARGET_FCLOOP

	tristate "NVMe over Fabrics FC Transport Loopback Test driver"

	depends on NVME_TARGET

	select NVME_CORE

	select NVME_FABRICS

	select SG_POOL

	depends on NVME_FC