Commit e19e9f47 authored by Amit Engel's avatar Amit Engel Committed by Christoph Hellwig
Browse files

nvmet: check that host sqsize does not exceed ctrl MQES 



Check that host sqsize is not greater-than Maximum Queue Entries
Supported (MQES) value supported by the controller.

Signed-off-by: default avatarAmit Engel <amit.engel@dell.com>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent b71df126

drivers/nvme/target/fabrics-cmd.c

+9 −0
Original line number Diff line number Diff line
@@ -109,6 +109,7 @@ static u16 nvmet_install_queue(struct nvmet_ctrl *ctrl, struct nvmet_req *req) 
	u16 qid = le16_to_cpu(c->qid);

	u16 sqsize = le16_to_cpu(c->sqsize);

	struct nvmet_ctrl *old;

	u16 mqes = NVME_CAP_MQES(ctrl->cap);

	u16 ret;



	if (!sqsize) {
@@ -125,6 +126,14 @@ static u16 nvmet_install_queue(struct nvmet_ctrl *ctrl, struct nvmet_req *req) 
		return NVME_SC_CMD_SEQ_ERROR | NVME_SC_DNR;

	}



	if (sqsize > mqes) {

		pr_warn("sqsize %u is larger than MQES supported %u cntlid %d\n",

				sqsize, mqes, ctrl->cntlid);

		req->error_loc = offsetof(struct nvmf_connect_command, sqsize);

		req->cqe->result.u32 = IPO_IATTR_CONNECT_SQE(sqsize);

		return NVME_SC_CONNECT_INVALID_PARAM | NVME_SC_DNR;

	}



	old = cmpxchg(&req->sq->ctrl, NULL, ctrl);

	if (old) {

		pr_warn("queue already connected!\n");