Unverified Commit 0325cc0a authored by Zhang Qilong's avatar Zhang Qilong Committed by Mark Brown
Browse files

ASoC: stm32: spdifrx: Fix PM disable depth imbalance in stm32_spdifrx_probe 



The pm_runtime_enable will increase power disable depth. Thus
a pairing decrement is needed on the error handling path to
keep it balanced according to context. We fix it by moving
pm_runtime_enable to the endding of stm32_spdifrx_probe.

Fixes:ac5e3efd ("ASoC: stm32: spdifrx: add pm_runtime support")

Signed-off-by: default avatarZhang Qilong <zhangqilong3@huawei.com>
Reviewed-by: default avatarOlivier Moysan <olivier.moysan@foss.st.com>
Link: https://lore.kernel.org/r/20220927142601.64266-3-zhangqilong3@huawei.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent b9a0da5b

sound/soc/stm/stm32_spdifrx.c

+2 −2
Original line number Diff line number Diff line
@@ -1002,8 +1002,6 @@ static int stm32_spdifrx_probe(struct platform_device *pdev) 
	udelay(2);

	reset_control_deassert(rst);



	pm_runtime_enable(&pdev->dev);



	pcm_config = &stm32_spdifrx_pcm_config;

	ret = snd_dmaengine_pcm_register(&pdev->dev, pcm_config, 0);

	if (ret)
@@ -1036,6 +1034,8 @@ static int stm32_spdifrx_probe(struct platform_device *pdev) 
			FIELD_GET(SPDIFRX_VERR_MIN_MASK, ver));

	}



	pm_runtime_enable(&pdev->dev);



	return ret;



error: