Unverified Commit b9a0da5b authored by Zhang Qilong's avatar Zhang Qilong Committed by Mark Brown
Browse files

ASoC: stm32: dfsdm: Fix PM disable depth imbalance in stm32_adfsdm_probe 



The pm_runtime_enable will increase power disable depth. Thus
a pairing decrement is needed on the error handling path to
keep it balanced according to context. We fix it by moving
pm_runtime_enable to the endding of stm32_adfsdm_probe.

Fixes:98e500a1 ("ASoC: stm32: dfsdm: add pm_runtime support for audio")

Signed-off-by: default avatarZhang Qilong <zhangqilong3@huawei.com>
Reviewed-by: default avatarOlivier Moysan <olivier.moysan@foss.st.com>
Link: https://lore.kernel.org/r/20220927142601.64266-2-zhangqilong3@huawei.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 45560891

sound/soc/stm/stm32_adfsdm.c

+5 −3
Original line number Diff line number Diff line
@@ -335,8 +335,6 @@ static int stm32_adfsdm_probe(struct platform_device *pdev) 


	dev_set_drvdata(&pdev->dev, priv);



	pm_runtime_enable(&pdev->dev);



	ret = devm_snd_soc_register_component(&pdev->dev,

					      &stm32_adfsdm_dai_component,

					      &priv->dai_drv, 1);
@@ -366,9 +364,13 @@ static int stm32_adfsdm_probe(struct platform_device *pdev) 
#endif



	ret = snd_soc_add_component(component, NULL, 0);

	if (ret < 0)

	if (ret < 0) {

		dev_err(&pdev->dev, "%s: Failed to register PCM platform\n",

			__func__);

		return ret;

	}



	pm_runtime_enable(&pdev->dev);



	return ret;

}