Commit 0148bb50 authored by Vladimir Oltean's avatar Vladimir Oltean Committed by Jakub Kicinski
Browse files

net: dsa: pass extack to dsa_switch_ops :: port_mirror_add() 



Drivers might have error messages to propagate to user space, most
common being that they support a single mirror port.

Propagate the netlink extack so that they can inform user space in a
verbal way of their limitations.

Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent f2a0e216

drivers/net/dsa/b53/b53_common.c

+2 −1
Original line number Diff line number Diff line
@@ -2110,7 +2110,8 @@ enum dsa_tag_protocol b53_get_tag_protocol(struct dsa_switch *ds, int port, 
EXPORT_SYMBOL(b53_get_tag_protocol);



int b53_mirror_add(struct dsa_switch *ds, int port,

		   struct dsa_mall_mirror_tc_entry *mirror, bool ingress)

		   struct dsa_mall_mirror_tc_entry *mirror, bool ingress,

		   struct netlink_ext_ack *extack)

{

	struct b53_device *dev = ds->priv;

	u16 reg, loc;

drivers/net/dsa/b53/b53_priv.h

+2 −1
Original line number Diff line number Diff line
@@ -373,7 +373,8 @@ int b53_mdb_del(struct dsa_switch *ds, int port, 
		const struct switchdev_obj_port_mdb *mdb,

		struct dsa_db db);

int b53_mirror_add(struct dsa_switch *ds, int port,

		   struct dsa_mall_mirror_tc_entry *mirror, bool ingress);

		   struct dsa_mall_mirror_tc_entry *mirror, bool ingress,

		   struct netlink_ext_ack *extack);

enum dsa_tag_protocol b53_get_tag_protocol(struct dsa_switch *ds, int port,

					   enum dsa_tag_protocol mprot);

void b53_mirror_del(struct dsa_switch *ds, int port,

drivers/net/dsa/microchip/ksz8795.c

+1 −1
Original line number Diff line number Diff line
@@ -1233,7 +1233,7 @@ static int ksz8_port_vlan_del(struct dsa_switch *ds, int port, 


static int ksz8_port_mirror_add(struct dsa_switch *ds, int port,

				struct dsa_mall_mirror_tc_entry *mirror,

				bool ingress)

				bool ingress, struct netlink_ext_ack *extack)

{

	struct ksz_device *dev = ds->priv;

drivers/net/dsa/microchip/ksz9477.c

+1 −1
Original line number Diff line number Diff line
@@ -1018,7 +1018,7 @@ static int ksz9477_port_mdb_del(struct dsa_switch *ds, int port, 


static int ksz9477_port_mirror_add(struct dsa_switch *ds, int port,

				   struct dsa_mall_mirror_tc_entry *mirror,

				   bool ingress)

				   bool ingress, struct netlink_ext_ack *extack)

{

	struct ksz_device *dev = ds->priv;

drivers/net/dsa/mt7530.c

+1 −1
Original line number Diff line number Diff line
@@ -1714,7 +1714,7 @@ static int mt753x_mirror_port_set(unsigned int id, u32 val) 


static int mt753x_port_mirror_add(struct dsa_switch *ds, int port,

				  struct dsa_mall_mirror_tc_entry *mirror,

				  bool ingress)

				  bool ingress, struct netlink_ext_ack *extack)

{

	struct mt7530_priv *priv = ds->priv;

	int monitor_port;