Commit f1d7fb7a authored by Brian King's avatar Brian King Committed by James Bottomley
Browse files

ibmvfc: Process async events before command responses 



Since async events could indicate changes to link status, or
events which could affect decisions made during discovery, we should
process async events prior to command completion responses.

Signed-off-by: default avatarBrian King <brking@linux.vnet.ibm.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
parent 7414705e

drivers/scsi/ibmvscsi/ibmvfc.c

+10 −10
Original line number Diff line number Diff line
@@ -2783,27 +2783,27 @@ static void ibmvfc_tasklet(void *data) 


	spin_lock_irqsave(vhost->host->host_lock, flags);

	while (!done) {

		/* Pull all the valid messages off the CRQ */

		while ((crq = ibmvfc_next_crq(vhost)) != NULL) {

			ibmvfc_handle_crq(crq, vhost);

			crq->valid = 0;

		}



		/* Pull all the valid messages off the async CRQ */

		while ((async = ibmvfc_next_async_crq(vhost)) != NULL) {

			ibmvfc_handle_async(async, vhost);

			async->valid = 0;

		}



		vio_enable_interrupts(vdev);

		if ((crq = ibmvfc_next_crq(vhost)) != NULL) {

			vio_disable_interrupts(vdev);

		/* Pull all the valid messages off the CRQ */

		while ((crq = ibmvfc_next_crq(vhost)) != NULL) {

			ibmvfc_handle_crq(crq, vhost);

			crq->valid = 0;

		} else if ((async = ibmvfc_next_async_crq(vhost)) != NULL) {

		}



		vio_enable_interrupts(vdev);

		if ((async = ibmvfc_next_async_crq(vhost)) != NULL) {

			vio_disable_interrupts(vdev);

			ibmvfc_handle_async(async, vhost);

			async->valid = 0;

		} else if ((crq = ibmvfc_next_crq(vhost)) != NULL) {

			vio_disable_interrupts(vdev);

			ibmvfc_handle_crq(crq, vhost);

			crq->valid = 0;

		} else

			done = 1;

	}