Commit eaa23765 authored by Andrew Lunn's avatar Andrew Lunn Committed by David S. Miller
Browse files

net: dsa: Centralise code for reading the temperature sensor 



The method to read the temperature used in the mve6123_61_65 driver
can also be used for other chips. Move the code into the shared code
base of mv88e6xxx.c.

Signed-off-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6f2aed6a

drivers/net/dsa/mv88e6123_61_65.c

+1 −49
Original line number Diff line number Diff line
@@ -291,54 +291,6 @@ static int mv88e6123_61_65_setup_port(struct dsa_switch *ds, int p) 
	return 0;

}



#ifdef CONFIG_NET_DSA_HWMON



static int  mv88e6123_61_65_get_temp(struct dsa_switch *ds, int *temp)

{

	struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);

	int ret;

	int val;



	*temp = 0;



	mutex_lock(&ps->phy_mutex);



	ret = mv88e6xxx_phy_write(ds, 0x0, 0x16, 0x6);

	if (ret < 0)

		goto error;



	/* Enable temperature sensor */

	ret = mv88e6xxx_phy_read(ds, 0x0, 0x1a);

	if (ret < 0)

		goto error;



	ret = mv88e6xxx_phy_write(ds, 0x0, 0x1a, ret | (1 << 5));

	if (ret < 0)

		goto error;



	/* Wait for temperature to stabilize */

	usleep_range(10000, 12000);



	val = mv88e6xxx_phy_read(ds, 0x0, 0x1a);

	if (val < 0) {

		ret = val;

		goto error;

	}



	/* Disable temperature sensor */

	ret = mv88e6xxx_phy_write(ds, 0x0, 0x1a, ret & ~(1 << 5));

	if (ret < 0)

		goto error;



	*temp = ((val & 0x1f) - 5) * 5;



error:

	mv88e6xxx_phy_write(ds, 0x0, 0x16, 0x0);

	mutex_unlock(&ps->phy_mutex);

	return ret;

}

#endif /* CONFIG_NET_DSA_HWMON */



static int mv88e6123_61_65_setup(struct dsa_switch *ds)

{

	struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);
@@ -471,7 +423,7 @@ struct dsa_switch_driver mv88e6123_61_65_switch_driver = { 
	.get_ethtool_stats	= mv88e6123_61_65_get_ethtool_stats,

	.get_sset_count		= mv88e6123_61_65_get_sset_count,

#ifdef CONFIG_NET_DSA_HWMON

	.get_temp		= mv88e6123_61_65_get_temp,

	.get_temp		= mv88e6xxx_get_temp,

#endif

	.get_regs_len		= mv88e6xxx_get_regs_len,

	.get_regs		= mv88e6xxx_get_regs,

drivers/net/dsa/mv88e6xxx.c

+48 −0
Original line number Diff line number Diff line
@@ -539,6 +539,54 @@ void mv88e6xxx_get_regs(struct dsa_switch *ds, int port, 
	}

}



#ifdef CONFIG_NET_DSA_HWMON



int  mv88e6xxx_get_temp(struct dsa_switch *ds, int *temp)

{

	struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);

	int ret;

	int val;



	*temp = 0;



	mutex_lock(&ps->phy_mutex);



	ret = mv88e6xxx_phy_write(ds, 0x0, 0x16, 0x6);

	if (ret < 0)

		goto error;



	/* Enable temperature sensor */

	ret = mv88e6xxx_phy_read(ds, 0x0, 0x1a);

	if (ret < 0)

		goto error;



	ret = mv88e6xxx_phy_write(ds, 0x0, 0x1a, ret | (1 << 5));

	if (ret < 0)

		goto error;



	/* Wait for temperature to stabilize */

	usleep_range(10000, 12000);



	val = mv88e6xxx_phy_read(ds, 0x0, 0x1a);

	if (val < 0) {

		ret = val;

		goto error;

	}



	/* Disable temperature sensor */

	ret = mv88e6xxx_phy_write(ds, 0x0, 0x1a, ret & ~(1 << 5));

	if (ret < 0)

		goto error;



	*temp = ((val & 0x1f) - 5) * 5;



error:

	mv88e6xxx_phy_write(ds, 0x0, 0x16, 0x0);

	mutex_unlock(&ps->phy_mutex);

	return ret;

}

#endif /* CONFIG_NET_DSA_HWMON */



static int __init mv88e6xxx_init(void)

{

#if IS_ENABLED(CONFIG_NET_DSA_MV88E6131)

drivers/net/dsa/mv88e6xxx.h

+1 −0
Original line number Diff line number Diff line
@@ -81,6 +81,7 @@ void mv88e6xxx_get_ethtool_stats(struct dsa_switch *ds, 
int mv88e6xxx_get_regs_len(struct dsa_switch *ds, int port);

void mv88e6xxx_get_regs(struct dsa_switch *ds, int port,

			struct ethtool_regs *regs, void *_p);

int  mv88e6xxx_get_temp(struct dsa_switch *ds, int *temp);



extern struct dsa_switch_driver mv88e6131_switch_driver;

extern struct dsa_switch_driver mv88e6123_61_65_switch_driver;