Commit e5b24439 authored by Dan Carpenter's avatar Dan Carpenter Committed by popcornmix
Browse files

staging: bcm2835-audio: double free in init error path 



commit 136ff5e49271c4c8fceeca5491c48e66b961564b upstream.

We free instance here and in the caller.  It should be only the caller
which handles it.

Fixes: d7ca3a71 ("staging: bcm2835-audio: Operate non-atomic PCM ops")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarTakashi Iwai <tiwai@suse.de>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 80ec8e12

drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c

+0 −1
Original line number Diff line number Diff line
@@ -145,7 +145,6 @@ vc_vchi_audio_init(VCHI_INSTANCE_T vchi_instance, 
		dev_err(instance->dev,

			"failed to open VCHI service connection (status=%d)\n",

			status);

		kfree(instance);

		return -EPERM;

	}