Commit d39e17c7 authored by Richard Weinberger's avatar Richard Weinberger Committed by Paul Mundt
Browse files

sh: remove warning and warning_symbol from struct stacktrace_ops 



Both warning and warning_symbol are nowhere used.
Let's get rid of them.

Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
Signed-off-by: default avatarPaul Mundt <lethal@linux-sh.org>
parent c7434dbf

arch/sh/include/asm/stacktrace.h

+0 −3
Original line number Diff line number Diff line
@@ -10,9 +10,6 @@ 
/* Generic stack tracer with callbacks */



struct stacktrace_ops {

	void (*warning)(void *data, char *msg);

	/* msg must contain %s for the symbol */

	void (*warning_symbol)(void *data, char *msg, unsigned long symbol);

	void (*address)(void *data, unsigned long address, int reliable);

	/* On negative return stop dumping */

	int (*stack)(void *data, char *name);

arch/sh/kernel/dumpstack.c

+0 −15
Original line number Diff line number Diff line
@@ -69,19 +69,6 @@ stack_reader_dump(struct task_struct *task, struct pt_regs *regs, 
	}

}



static void

print_trace_warning_symbol(void *data, char *msg, unsigned long symbol)

{

	printk(data);

	print_symbol(msg, symbol);

	printk("\n");

}



static void print_trace_warning(void *data, char *msg)

{

	printk("%s%s\n", (char *)data, msg);

}



static int print_trace_stack(void *data, char *name)

{

	printk("%s <%s> ", (char *)data, name);
@@ -98,8 +85,6 @@ static void print_trace_address(void *data, unsigned long addr, int reliable) 
}



static const struct stacktrace_ops print_trace_ops = {

	.warning = print_trace_warning,

	.warning_symbol = print_trace_warning_symbol,

	.stack = print_trace_stack,

	.address = print_trace_address,

};

arch/sh/kernel/perf_callchain.c

+0 −12
Original line number Diff line number Diff line
@@ -14,16 +14,6 @@ 
#include <asm/unwinder.h>

#include <asm/ptrace.h>





static void callchain_warning(void *data, char *msg)

{

}



static void

callchain_warning_symbol(void *data, char *msg, unsigned long symbol)

{

}



static int callchain_stack(void *data, char *name)

{

	return 0;
@@ -38,8 +28,6 @@ static void callchain_address(void *data, unsigned long addr, int reliable) 
}



static const struct stacktrace_ops callchain_ops = {

	.warning	= callchain_warning,

	.warning_symbol	= callchain_warning_symbol,

	.stack		= callchain_stack,

	.address	= callchain_address,

};

arch/sh/kernel/stacktrace.c

+0 −13
Original line number Diff line number Diff line
@@ -17,15 +17,6 @@ 
#include <asm/ptrace.h>

#include <asm/stacktrace.h>



static void save_stack_warning(void *data, char *msg)

{

}



static void

save_stack_warning_symbol(void *data, char *msg, unsigned long symbol)

{

}



static int save_stack_stack(void *data, char *name)

{

	return 0;
@@ -51,8 +42,6 @@ static void save_stack_address(void *data, unsigned long addr, int reliable) 
}



static const struct stacktrace_ops save_stack_ops = {

	.warning = save_stack_warning,

	.warning_symbol = save_stack_warning_symbol,

	.stack = save_stack_stack,

	.address = save_stack_address,

};
@@ -88,8 +77,6 @@ save_stack_address_nosched(void *data, unsigned long addr, int reliable) 
}



static const struct stacktrace_ops save_stack_ops_nosched = {

	.warning = save_stack_warning,

	.warning_symbol = save_stack_warning_symbol,

	.stack = save_stack_stack,

	.address = save_stack_address_nosched,

};

arch/sh/oprofile/backtrace.c

+0 −13
Original line number Diff line number Diff line
@@ -23,17 +23,6 @@ 
#include <asm/sections.h>

#include <asm/stacktrace.h>



static void backtrace_warning_symbol(void *data, char *msg,

				     unsigned long symbol)

{

	/* Ignore warnings */

}



static void backtrace_warning(void *data, char *msg)

{

	/* Ignore warnings */

}



static int backtrace_stack(void *data, char *name)

{

	/* Yes, we want all stacks */
@@ -49,8 +38,6 @@ static void backtrace_address(void *data, unsigned long addr, int reliable) 
}



static struct stacktrace_ops backtrace_ops = {

	.warning = backtrace_warning,

	.warning_symbol = backtrace_warning_symbol,

	.stack = backtrace_stack,

	.address = backtrace_address,

};