Commit cd54dc4c authored by Ido Schimmel's avatar Ido Schimmel Committed by Greg Kroah-Hartman
Browse files

mlxsw: spectrum: Handle VLAN device unlinking 



[ Upstream commit e149113a ]

In commit 993107fe ("mlxsw: spectrum_switchdev: Fix VLAN device
deletion via ioctl") I fixed a bug caused by the fact that the driver
views differently the deletion of a VLAN device when it is deleted via
an ioctl and netlink.

Instead of relying on a specific order of events (device being
unregistered vs. VLAN filter being updated), simply make sure that the
driver performs the necessary cleanup when the VLAN device is unlinked,
which always happens before the other two events.

Signed-off-by: default avatarIdo Schimmel <idosch@mellanox.com>
Reviewed-by: default avatarPetr Machata <petrm@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent a8a296ab

drivers/net/ethernet/mellanox/mlxsw/spectrum.c

+10 −0
Original line number Diff line number Diff line
@@ -4681,6 +4681,16 @@ static int mlxsw_sp_netdevice_port_upper_event(struct net_device *lower_dev, 
		} else if (netif_is_macvlan(upper_dev)) {

			if (!info->linking)

				mlxsw_sp_rif_macvlan_del(mlxsw_sp, upper_dev);

		} else if (is_vlan_dev(upper_dev)) {

			struct net_device *br_dev;



			if (!netif_is_bridge_port(upper_dev))

				break;

			if (info->linking)

				break;

			br_dev = netdev_master_upper_dev_get(upper_dev);

			mlxsw_sp_port_bridge_leave(mlxsw_sp_port, upper_dev,

						   br_dev);

		}

		break;

	}