Commit c4e90ec0 authored by Florin Malita's avatar Florin Malita Committed by Artem Bityutskiy
Browse files

UBI: fix dereference after kfree 



Coverity (CID 1614) spotted new_seb being dereferenced after kfree() in
create_vtbl's write_error path.

Signed-off-by: default avatarFlorin Malita <fmalita@gmail.com>
Signed-off-by: default avatarArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
parent 341e1a0c

drivers/mtd/ubi/vtbl.c

+5 −6
Original line number Original line Diff line number Diff line
@@ -317,14 +317,13 @@ retry: 
	return err;

	return err;





write_error:

write_error:

	kfree(new_seb);

	/* Maybe this physical eraseblock went bad, try to pick another one */

	/* Maybe this physical eraseblock went bad, try to pick another one */

	if (++tries <= 5) {

	if (++tries <= 5)

		err = ubi_scan_add_to_list(si, new_seb->pnum, new_seb->ec,

		err = ubi_scan_add_to_list(si, new_seb->pnum, new_seb->ec,

					   &si->corr);

					   &si->corr);

	kfree(new_seb);

	if (!err)

	if (!err)

		goto retry;

		goto retry;

	}

out_free:

out_free:

	ubi_free_vid_hdr(ubi, vid_hdr);

	ubi_free_vid_hdr(ubi, vid_hdr);

	return err;

	return err;