Commit ba623a77 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jiri Kosina
Browse files

HID: unlock on error path in hid_device_probe() 



We recently introduced locking into this function, but we missed an
error path which needs an unlock.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 54d3339a

drivers/hid/hid-core.c

+5 −3
Original line number Diff line number Diff line
@@ -1642,8 +1642,10 @@ static int hid_device_probe(struct device *dev) 


	if (!hdev->driver) {

		id = hid_match_device(hdev, hdrv);

		if (id == NULL)

			return -ENODEV;

		if (id == NULL) {

			ret = -ENODEV;

			goto unlock;

		}



		hdev->driver = hdrv;

		if (hdrv->probe) {
@@ -1656,7 +1658,7 @@ static int hid_device_probe(struct device *dev) 
		if (ret)

			hdev->driver = NULL;

	}



unlock:

	up(&hdev->driver_lock);

	return ret;

}