Commit 9bb3d5a0 authored by Emmanuel Grumbach's avatar Emmanuel Grumbach Committed by Luca Coelho
Browse files

iwlwifi: pcie: free the TSO page when a Tx queue is unmapped on A000 devices 



When we unmap a non-empty Tx queue, we need to free the
pages that we allocated for the headers in TSO flows.
This code existed for the 9000 device family, but somehow
it got left out when the new Tx path for the A000 devices
was written.

Fixes: 2b0c5946d9ed ("iwlwifi: pcie: introduce a000 TX queues management")
Signed-off-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
parent fb70d49f

drivers/net/wireless/intel/iwlwifi/pcie/internal.h

+2 −0
Original line number Diff line number Diff line
@@ -806,6 +806,8 @@ int iwl_pcie_alloc_dma_ptr(struct iwl_trans *trans, 
			   struct iwl_dma_ptr *ptr, size_t size);

void iwl_pcie_free_dma_ptr(struct iwl_trans *trans, struct iwl_dma_ptr *ptr);

void iwl_pcie_apply_destination(struct iwl_trans *trans);

void iwl_pcie_free_tso_page(struct iwl_trans_pcie *trans_pcie,

			    struct sk_buff *skb);

#ifdef CONFIG_INET

struct iwl_tso_hdr_page *get_page_hdr(struct iwl_trans *trans, size_t len);

#endif

drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c

+9 −0
Original line number Diff line number Diff line
@@ -937,6 +937,15 @@ void iwl_pcie_gen2_txq_unmap(struct iwl_trans *trans, int txq_id) 
		IWL_DEBUG_TX_REPLY(trans, "Q %d Free %d\n",

				   txq_id, txq->read_ptr);



		if (txq_id != trans_pcie->cmd_queue) {

			int idx = get_cmd_index(txq, txq->read_ptr);

			struct sk_buff *skb = txq->entries[idx].skb;



			if (WARN_ON_ONCE(!skb))

				continue;



			iwl_pcie_free_tso_page(trans_pcie, skb);

		}

		iwl_pcie_gen2_free_tfd(trans, txq);

		txq->read_ptr = iwl_queue_inc_wrap(txq->read_ptr);

drivers/net/wireless/intel/iwlwifi/pcie/tx.c

+2 −2
Original line number Diff line number Diff line
@@ -577,7 +577,7 @@ int iwl_pcie_txq_init(struct iwl_trans *trans, struct iwl_txq *txq, 
	return 0;

}



static void iwl_pcie_free_tso_page(struct iwl_trans_pcie *trans_pcie,

void iwl_pcie_free_tso_page(struct iwl_trans_pcie *trans_pcie,

			    struct sk_buff *skb)

{

	struct page **page_ptr;