Commit 87009d86 authored by Dmitry Monakhov's avatar Dmitry Monakhov Committed by Theodore Ts'o
Browse files

ext4: do not try to grab the s_umount semaphore in ext4_quota_off 



It's not needed to sync the filesystem, and it fixes a lock_dep complaint.

Signed-off-by: default avatarDmitry Monakhov <dmonakhov@gmail.com>
Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
parent 83668e71

fs/ext4/super.c

+3 −5
Original line number Diff line number Diff line
@@ -4570,12 +4570,10 @@ static int ext4_quota_on(struct super_block *sb, int type, int format_id, 


static int ext4_quota_off(struct super_block *sb, int type)

{

	/* Force all delayed allocation blocks to be allocated */

	if (test_opt(sb, DELALLOC)) {

		down_read(&sb->s_umount);

	/* Force all delayed allocation blocks to be allocated.

	 * Caller already holds s_umount sem */

	if (test_opt(sb, DELALLOC))

		sync_filesystem(sb);

		up_read(&sb->s_umount);

	}



	return dquot_quota_off(sb, type);

}