Commit 85bfb4da authored Oct 22, 2007 by NeilBrown Committed by Linus Torvalds Oct 23, 2007

md: fix an unsigned compare to allow creation of bitmaps with v1.0 metadata



As page->index is unsigned, this all becomes an unsigned comparison,
which almost always returns an error.

Signed-off-by: Neil Brown <neilb@suse.de>
Cc: Stable <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 0895e91d

drivers/md/bitmap.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -274,7 +274,7 @@ static int write_sb_page(struct bitmap bitmap, struct page page, int wait)
		if (bitmap->offset < 0) {
		/* DATA BITMAP METADATA */
		if (bitmap->offset
		+ page->index * (PAGE_SIZE/512)
		+ (long)(page->index * (PAGE_SIZE/512))
		+ size/512 > 0)
		/* bitmap runs in to metadata */
		return -EINVAL;