Commit 80c76fe3 authored by Weston Andros Adamson's avatar Weston Andros Adamson Committed by Tom Haynes
Browse files

pnfs: fail comparison when bucket verifier not set 



This skips the WARN_ON_ONCE, but doesnt change behavior (the memcmp would
fail).

Signed-off-by: default avatarWeston Andros Adamson <dros@primarydata.com>
Signed-off-by: default avatarTom Haynes <Thomas.Haynes@primarydata.com>
parent 0a00b77b

fs/nfs/direct.c

+5 −1
Original line number Diff line number Diff line
@@ -222,7 +222,11 @@ static int nfs_direct_cmp_commit_data_verf(struct nfs_direct_req *dreq, 


	verfp = nfs_direct_select_verf(dreq, data->ds_clp,

					 data->ds_commit_index);

	WARN_ON_ONCE(verfp->committed < 0);



	/* verifier not set so always fail */

	if (verfp->committed < 0)

		return 1;



	return memcmp(verfp, &data->verf, sizeof(struct nfs_writeverf));

}