Commit 7abd75bf authored Jul 02, 2015 by Nishanth Aravamudan Committed by Herbert Xu Jul 06, 2015

crypto: nx - do not emit extra output if status is disabled



If the device-tree indicates the nx-842 device's status is 'disabled',
we emit two messages:

nx_compress_pseries ibm,compression-v1: nx842_OF_upd_status: status 'disabled' is not 'okay'.
nx_compress_pseries ibm,compression-v1: nx842_OF_upd: device disabled

Given that 'disabled' is a valid state, and we are going to emit that
the device is disabled, only print out a non-'okay' status if it is not
'disabled'.

Signed-off-by: Nishanth Aravamudan <nacc@linux.vnet.ibm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent ec13bcbe

drivers/crypto/nx/nx-842-pseries.c

+7 −1

Original line number	Diff line number	Diff line
		@@ -566,8 +566,14 @@ static int nx842_OF_upd_status(struct nx842_devdata *devdata,
		if (!strncmp(status, "okay", (size_t)prop->length)) {
		devdata->status = AVAILABLE;
		} else {
		/*
		* Caller will log that the device is disabled, so only
		* output if there is an unexpected status.
		*/
		if (strncmp(status, "disabled", (size_t)prop->length)) {
		dev_info(devdata->dev, "%s: status '%s' is not 'okay'\n",
		__func__, status);
		}
		devdata->status = UNAVAILABLE;
		ret = -ENODEV;
		}