Commit 71dc525c authored by Julien Brunel's avatar Julien Brunel Committed by Jaroslav Kysela
Browse files

ALSA: sound/soc/at32: Useless NULL test 

The test (ssc != NULL) can only be reached if the call to the function
ssc_request, the result of which ssc is assigned, succeeds. Moreover,
two statements assign NULL to ssc just before a return, which is useless
since it is a local variable. So, we suggest to delete the test and
the two assignments.

A simplified version of the semantic match that finds this problem is
as follows:
(http://www.emn.fr/x-info/coccinelle/

)

// <smpl>
@bad_null_test@
expression x,E;
@@
x = ssc_request(...)
... when != x = E
* x != NULL
// </smpl>

Signed-off-by: default avatarJulien Brunel <brunel@diku.dk>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Acked-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarJaroslav Kysela <perex@perex.cz>
parent 9a9e2359

sound/soc/at32/playpaq_wm8510.c

+1 −5
Original line number Diff line number Diff line
@@ -406,7 +406,6 @@ static int __init playpaq_asoc_init(void) 
	ssc = ssc_request(0);

	if (IS_ERR(ssc)) {

		ret = PTR_ERR(ssc);

		ssc = NULL;

		goto err_ssc;

	}

	ssc_p->ssc = ssc;
@@ -477,10 +476,7 @@ err_pll0: 
		_gclk0 = NULL;

	}

err_gclk0:

	if (ssc != NULL) {

	ssc_free(ssc);

		ssc = NULL;

	}

err_ssc:

	return ret;

}