Commit 6a869d07 authored by Dave Stevenson's avatar Dave Stevenson Committed by Phil Elwell
Browse files

staging: bcm2835_camera: Ensure all buffers are returned on disable 



With the recent change to match MMAL and V4L2 buffers there
is a need to wait for all MMAL buffers to be returned during
stop_streaming.

Fixes: 93841670 "staging: bcm2835-camera: Remove V4L2/MMAL buffer remapping"
Signed-off-by: default avatarDave Stevenson <dave.stevenson@raspberrypi.org>
parent 3bd3cffd

drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c

+16 −6
Original line number Diff line number Diff line
@@ -614,6 +614,7 @@ static void stop_streaming(struct vb2_queue *vq) 
{

	int ret;

	struct bm2835_mmal_dev *dev = vb2_get_drv_priv(vq);

	struct vchiq_mmal_port *port = dev->capture.port;



	v4l2_dbg(1, bcm2835_v4l2_debug, &dev->v4l2_dev, "%s: dev:%p\n",

		 __func__, dev);
@@ -637,12 +638,6 @@ static void stop_streaming(struct vb2_queue *vq) 
				      &dev->capture.frame_count,

				      sizeof(dev->capture.frame_count));



	/* wait for last frame to complete */

	ret = wait_for_completion_timeout(&dev->capture.frame_cmplt, HZ);

	if (ret <= 0)

		v4l2_err(&dev->v4l2_dev,

			 "error %d waiting for frame completion\n", ret);



	v4l2_dbg(1, bcm2835_v4l2_debug, &dev->v4l2_dev,

		 "disabling connection\n");
@@ -657,6 +652,21 @@ static void stop_streaming(struct vb2_queue *vq) 
			 ret);

	}



	/* wait for all buffers to be returned */

	while (atomic_read(&port->buffers_with_vpu)) {

		v4l2_dbg(1, bcm2835_v4l2_debug, &dev->v4l2_dev,

			 "%s: Waiting for buffers to be returned - %d outstanding\n",

			 __func__, atomic_read(&port->buffers_with_vpu));

		ret = wait_for_completion_timeout(&dev->capture.frame_cmplt,

						  HZ);

		if (ret <= 0) {

			v4l2_err(&dev->v4l2_dev, "%s: Timeout waiting for buffers to be returned - %d outstanding\n",

				 __func__,

				 atomic_read(&port->buffers_with_vpu));

			break;

		}

	}



	if (disable_camera(dev) < 0)

		v4l2_err(&dev->v4l2_dev, "Failed to disable camera\n");

}

drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c

+4 −0
Original line number Diff line number Diff line
@@ -318,6 +318,8 @@ static void buffer_work_cb(struct work_struct *work) 
	struct mmal_msg_context *msg_context =

		container_of(work, struct mmal_msg_context, u.bulk.work);



	atomic_dec(&msg_context->u.bulk.port->buffers_with_vpu);



	msg_context->u.bulk.port->buffer_cb(msg_context->u.bulk.instance,

					    msg_context->u.bulk.port,

					    msg_context->u.bulk.status,
@@ -461,6 +463,8 @@ buffer_from_host(struct vchiq_mmal_instance *instance, 
	INIT_WORK(&msg_context->u.bulk.buffer_to_host_work,

		  buffer_to_host_work_cb);



	atomic_inc(&port->buffers_with_vpu);



	/* prep the buffer from host message */

	memset(&m, 0xbc, sizeof(m));	/* just to make debug clearer */

drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.h

+3 −0
Original line number Diff line number Diff line
@@ -75,6 +75,9 @@ struct vchiq_mmal_port { 
	struct list_head buffers;

	/* lock to serialise adding and removing buffers from list */

	spinlock_t slock;



	/* Count of buffers the VPU has yet to return */

	atomic_t buffers_with_vpu;

	/* callback on buffer completion */

	vchiq_mmal_buffer_cb buffer_cb;

	/* callback context */