Commit 675e29ff authored by Dave Stevenson's avatar Dave Stevenson Committed by Phil Elwell
Browse files

media: ov5647: Use gpiod_set_value_cansleep 



All calls to the gpio library are in contexts that can sleep,
therefore there is no issue with having those GPIOs controlled
by controllers which require sleeping (eg I2C GPIO expanders).

Switch to using gpiod_set_value_cansleep instead of gpiod_set_value
to avoid triggering the warning in gpiolib should the GPIO
controller need to sleep.

Signed-off-by: default avatarDave Stevenson <dave.stevenson@raspberrypi.org>
parent 71538ec0

drivers/media/i2c/ov5647.c

+4 −4
Original line number Diff line number Diff line
@@ -348,7 +348,7 @@ static int ov5647_sensor_power(struct v4l2_subdev *sd, int on) 
		dev_dbg(&client->dev, "OV5647 power on\n");



		if (ov5647->pwdn) {

			gpiod_set_value(ov5647->pwdn, 0);

			gpiod_set_value_cansleep(ov5647->pwdn, 0);

			msleep(PWDN_ACTIVE_DELAY_MS);

		}
@@ -390,7 +390,7 @@ static int ov5647_sensor_power(struct v4l2_subdev *sd, int on) 


		clk_disable_unprepare(ov5647->xclk);



		gpiod_set_value(ov5647->pwdn, 1);

		gpiod_set_value_cansleep(ov5647->pwdn, 1);

	}



	/* Update the power count. */
@@ -624,13 +624,13 @@ static int ov5647_probe(struct i2c_client *client, 
		goto mutex_remove;



	if (sensor->pwdn) {

		gpiod_set_value(sensor->pwdn, 0);

		gpiod_set_value_cansleep(sensor->pwdn, 0);

		msleep(PWDN_ACTIVE_DELAY_MS);

	}



	ret = ov5647_detect(sd);



	gpiod_set_value(sensor->pwdn, 1);

	gpiod_set_value_cansleep(sensor->pwdn, 1);



	if (ret < 0)

		goto error;