Commit 5d7dab83 authored by Benny Halevy's avatar Benny Halevy Committed by J. Bruce Fields
Browse files

nfsd: nfs4_open_delegation needs to remove_stid rather than unhash_stid 



In the out_free: path, the newly allocated stid must be removed rather
than unhashed so it can never be found.

Signed-off-by: default avatarBenny Halevy <bhalevy@primarydata.com>
Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
parent 9857df81

fs/nfsd/nfs4state.c

+1 −1
Original line number Diff line number Diff line
@@ -3159,7 +3159,7 @@ nfs4_open_delegation(struct net *net, struct svc_fh *fh, 
	open->op_delegate_type = NFS4_OPEN_DELEGATE_READ;

	return;

out_free:

	unhash_stid(&dp->dl_stid);

	remove_stid(&dp->dl_stid);

	nfs4_put_delegation(dp);

out_no_deleg:

	open->op_delegate_type = NFS4_OPEN_DELEGATE_NONE;