Commit 56eb82bb authored by Vlad Yasevich's avatar Vlad Yasevich Committed by David S. Miller
Browse files

sctp: Fix SNMP number of SCTP_MIB_ABORTED during violation handling. 



If ABORT chunks require authentication and a protocol violation
is triggered, we do not tear down the association.  Subsequently,
we should not increment SCTP_MIB_ABORTED.

Signed-off-by: default avatarVlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3d5a019d

net/sctp/sm_statefuns.c

+3 −6
Original line number Diff line number Diff line
@@ -4188,11 +4188,10 @@ static sctp_disposition_t sctp_sf_abort_violation( 
		SCTP_INC_STATS(SCTP_MIB_OUTCTRLCHUNKS);

	}



discard:

	sctp_sf_pdiscard(ep, asoc, SCTP_ST_CHUNK(0), arg, commands);



	SCTP_INC_STATS(SCTP_MIB_ABORTEDS);



discard:

	sctp_sf_pdiscard(ep, asoc, SCTP_ST_CHUNK(0), arg, commands);

	return SCTP_DISPOSITION_ABORT;



nomem_pkt:
@@ -4265,12 +4264,10 @@ static sctp_disposition_t sctp_sf_violation_paramlen( 
	sctp_add_cmd_sf(commands, SCTP_CMD_ASSOC_FAILED,

			SCTP_PERR(SCTP_ERROR_PROTO_VIOLATION));

	SCTP_DEC_STATS(SCTP_MIB_CURRESTAB);

	SCTP_INC_STATS(SCTP_MIB_ABORTEDS);



discard:

	sctp_sf_pdiscard(ep, asoc, SCTP_ST_CHUNK(0), arg, commands);



	SCTP_INC_STATS(SCTP_MIB_ABORTEDS);



	return SCTP_DISPOSITION_ABORT;

nomem:

	return SCTP_DISPOSITION_NOMEM;