Commit 4408dd15 authored by Andre Guedes's avatar Andre Guedes Committed by Marcel Holtmann
Browse files

Bluetooth: Use memdup_user in le_auto_conn_write() 



This patch does a small code simplification replacing the tipical
kmalloc-copy_from_user sequence by memdup_user() helper.

Cc: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: default avatarAndre Guedes <andre.guedes@openbossa.org>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent 4af605d8

net/bluetooth/hci_core.c

+3 −8
Original line number Diff line number Diff line
@@ -955,14 +955,9 @@ static ssize_t le_auto_conn_write(struct file *file, const char __user *data, 
	if (count < 3)

		return -EINVAL;



	buf = kzalloc(count, GFP_KERNEL);

	if (!buf)

		return -ENOMEM;



	if (copy_from_user(buf, data, count)) {

		err = -EFAULT;

		goto done;

	}

	buf = memdup_user(data, count);

	if (IS_ERR(buf))

		return PTR_ERR(buf);



	if (memcmp(buf, "add", 3) == 0) {

		n = sscanf(&buf[4], "%hhx:%hhx:%hhx:%hhx:%hhx:%hhx %hhu %hhu",