Commit 2b93f7ee authored by Nishanth Aravamudan's avatar Nishanth Aravamudan Committed by Herbert Xu
Browse files

crypto: nx - reduce chattiness of platform drivers 



While we never would successfully load on the wrong machine type, there
is extra output by default regardless of machine type.

For instance, on a PowerVM LPAR, we see the following:

nx_compress_powernv: loading
nx_compress_powernv: no coprocessors found

even though those coprocessors could never be found.

Signed-off-by: default avatarNishanth Aravamudan <nacc@linux.vnet.ibm.com>
Cc: Dan Streetman <ddstreet@us.ibm.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-crypto@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org
Acked-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 0d8dc966

drivers/crypto/nx/nx-842-powernv.c

+1 −9
Original line number Diff line number Diff line
@@ -594,15 +594,11 @@ static __init int nx842_powernv_init(void) 
	BUILD_BUG_ON(DDE_BUFFER_ALIGN % DDE_BUFFER_SIZE_MULT);

	BUILD_BUG_ON(DDE_BUFFER_SIZE_MULT % DDE_BUFFER_LAST_MULT);



	pr_info("loading\n");



	for_each_compatible_node(dn, NULL, "ibm,power-nx")

		nx842_powernv_probe(dn);



	if (!nx842_ct) {

		pr_err("no coprocessors found\n");

	if (!nx842_ct)

		return -ENODEV;

	}



	if (!nx842_platform_driver_set(&nx842_powernv_driver)) {

		struct nx842_coproc *coproc, *n;
@@ -615,8 +611,6 @@ static __init int nx842_powernv_init(void) 
		return -EEXIST;

	}



	pr_info("loaded\n");



	return 0;

}

module_init(nx842_powernv_init);
@@ -631,7 +625,5 @@ static void __exit nx842_powernv_exit(void) 
		list_del(&coproc->list);

		kfree(coproc);

	}



	pr_info("unloaded\n");

}

module_exit(nx842_powernv_exit);

drivers/crypto/nx/nx-842-pseries.c

+0 −3
Original line number Diff line number Diff line
@@ -1091,8 +1091,6 @@ static int __init nx842_pseries_init(void) 
	struct nx842_devdata *new_devdata;

	int ret;



	pr_info("Registering IBM Power 842 compression driver\n");



	if (!of_find_compatible_node(NULL, NULL, "ibm,compression"))

		return -ENODEV;
@@ -1129,7 +1127,6 @@ static void __exit nx842_pseries_exit(void) 
	struct nx842_devdata *old_devdata;

	unsigned long flags;



	pr_info("Exiting IBM Power 842 compression driver\n");

	nx842_platform_driver_unset(&nx842_pseries_driver);

	spin_lock_irqsave(&devdata_mutex, flags);

	old_devdata = rcu_dereference_check(devdata,