Commit 27b11428 authored by J. Bruce Fields's avatar J. Bruce Fields
Browse files

nfsd4: warn on finding lockowner without stateid's 



The current code assumes a one-to-one lockowner<->lock stateid
correspondance.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
parent a1b8ff4c

fs/nfsd/nfs4state.c

+4 −0
Original line number Diff line number Diff line
@@ -4166,6 +4166,10 @@ static bool same_lockowner_ino(struct nfs4_lockowner *lo, struct inode *inode, c 


	if (!same_owner_str(&lo->lo_owner, owner, clid))

		return false;

	if (list_empty(&lo->lo_owner.so_stateids)) {

		WARN_ON_ONCE(1);

		return false;

	}

	lst = list_first_entry(&lo->lo_owner.so_stateids,

			       struct nfs4_ol_stateid, st_perstateowner);

	return lst->st_file->fi_inode == inode;