Commit 27399350 authored Sep 06, 2018 by Parav Pandit Committed by Jason Gunthorpe Sep 06, 2018

RDMA/core: Assign device ifindex before publishing the device



Even though device->ifindex is assigned before adding the device in the
list which is read by netlink flow, it is better to assign rdma device
index before publishing the device in the system to users and clients.

Signed-off-by: Parav Pandit <parav@mellanox.com>
Reviewed-by: Daniel Jurgens <danielj@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent c715a395

drivers/infiniband/core/device.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -525,6 +525,8 @@ int ib_register_device(struct ib_device *device,
		goto port_cleanup;
		}

		device->index = __dev_new_index();

		ret = ib_device_register_rdmacg(device);
		if (ret) {
		pr_warn("Couldn't register device with rdma cgroup\n");
		@@ -551,7 +553,6 @@ int ib_register_device(struct ib_device *device,
		if (!add_client_context(device, client) && client->add)
		client->add(device);

		device->index = __dev_new_index();
		down_write(&lists_rwsem);
		list_add_tail(&device->core_list, &device_list);
		up_write(&lists_rwsem);