Commit 09a62660 authored by Kris Katterjohn's avatar Kris Katterjohn Committed by David S. Miller
Browse files

[NET]: Change some "if (x) BUG();" to "BUG_ON(x);" 



This changes some simple "if (x) BUG();" statements to "BUG_ON(x);"

Signed-off-by: default avatarKris Katterjohn <kjak@users.sourceforge.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4bba3925

net/core/dev.c

+3 −6
Original line number Diff line number Diff line
@@ -1092,15 +1092,12 @@ int skb_checksum_help(struct sk_buff *skb, int inward) 
			goto out;

	}



	if (offset > (int)skb->len)

		BUG();

	BUG_ON(offset > (int)skb->len);

	csum = skb_checksum(skb, offset, skb->len-offset, 0);



	offset = skb->tail - skb->h.raw;

	if (offset <= 0)

		BUG();

	if (skb->csum + 2 > offset)

		BUG();

	BUG_ON(offset <= 0);

	BUG_ON(skb->csum + 2 > offset);



	*(u16*)(skb->h.raw + skb->csum) = csum_fold(csum);

	skb->ip_summed = CHECKSUM_NONE;

net/core/skbuff.c

+5 −10
Original line number Diff line number Diff line
@@ -791,8 +791,7 @@ int ___pskb_trim(struct sk_buff *skb, unsigned int len, int realloc) 
		int end = offset + skb_shinfo(skb)->frags[i].size;

		if (end > len) {

			if (skb_cloned(skb)) {

				if (!realloc)

					BUG();

				BUG_ON(!realloc);

				if (pskb_expand_head(skb, 0, 0, GFP_ATOMIC))

					return -ENOMEM;

			}
@@ -894,8 +893,7 @@ unsigned char *__pskb_pull_tail(struct sk_buff *skb, int delta) 
		struct sk_buff *insp = NULL;



		do {

			if (!list)

				BUG();

			BUG_ON(!list);



			if (list->len <= eat) {

				/* Eaten as whole. */
@@ -1199,8 +1197,7 @@ unsigned int skb_checksum(const struct sk_buff *skb, int offset, 
			start = end;

		}

	}

	if (len)

		BUG();

	BUG_ON(len);



	return csum;

}
@@ -1282,8 +1279,7 @@ unsigned int skb_copy_and_csum_bits(const struct sk_buff *skb, int offset, 
			start = end;

		}

	}

	if (len)

		BUG();

	BUG_ON(len);

	return csum;

}
@@ -1297,8 +1293,7 @@ void skb_copy_and_csum_dev(const struct sk_buff *skb, u8 *to) 
	else

		csstart = skb_headlen(skb);



	if (csstart > skb_headlen(skb))

		BUG();

	BUG_ON(csstart > skb_headlen(skb));



	memcpy(to, skb->data, csstart);

net/ipv4/icmp.c

+1 −2
Original line number Diff line number Diff line
@@ -899,8 +899,7 @@ static void icmp_address_reply(struct sk_buff *skb) 
		u32 _mask, *mp;



		mp = skb_header_pointer(skb, 0, sizeof(_mask), &_mask);

		if (mp == NULL)

			BUG();

		BUG_ON(mp == NULL);

		for (ifa = in_dev->ifa_list; ifa; ifa = ifa->ifa_next) {

			if (*mp == ifa->ifa_mask &&

			    inet_ifa_match(rt->rt_src, ifa))

net/ipv4/inetpeer.c

+2 −4
Original line number Diff line number Diff line
@@ -304,8 +304,7 @@ static void unlink_from_pool(struct inet_peer *p) 
			/* look for a node to insert instead of p */

			struct inet_peer *t;

			t = lookup_rightempty(p);

			if (*stackptr[-1] != t)

				BUG();

			BUG_ON(*stackptr[-1] != t);

			**--stackptr = t->avl_left;

			/* t is removed, t->v4daddr > x->v4daddr for any

			 * x in p->avl_left subtree.
@@ -314,8 +313,7 @@ static void unlink_from_pool(struct inet_peer *p) 
			t->avl_left = p->avl_left;

			t->avl_right = p->avl_right;

			t->avl_height = p->avl_height;

			if (delp[1] != &p->avl_left)

				BUG();

			BUG_ON(delp[1] != &p->avl_left);

			delp[1] = &t->avl_left; /* was &p->avl_left */

		}

		peer_avl_rebalance(stack, stackptr);

net/ipv4/tcp_input.c

+1 −1
Original line number Diff line number Diff line
@@ -3347,7 +3347,7 @@ tcp_collapse(struct sock *sk, struct sk_buff_head *list, 
			int offset = start - TCP_SKB_CB(skb)->seq;

			int size = TCP_SKB_CB(skb)->end_seq - start;



			if (offset < 0) BUG();

			BUG_ON(offset < 0);

			if (size > 0) {

				size = min(copy, size);

				if (skb_copy_bits(skb, offset, skb_put(nskb, size), size))