Commit e37abe97 authored by David Sterba's avatar David Sterba
Browse files

btrfs: open code btrfs_dev_replace_stats_inc 



The wrapper is too trivial, open coding does not make it less readable.

Reviewed-by: default avatarOmar Sandoval <osandov@fb.com>
Reviewed-by: default avatarAnand Jain <anand.jain@oracle.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 7fb2eced

fs/btrfs/dev-replace.h

+0 −5
Original line number Diff line number Diff line
@@ -29,9 +29,4 @@ void btrfs_dev_replace_write_lock(struct btrfs_dev_replace *dev_replace); 
void btrfs_dev_replace_write_unlock(struct btrfs_dev_replace *dev_replace);

void btrfs_dev_replace_set_lock_blocking(struct btrfs_dev_replace *dev_replace);



static inline void btrfs_dev_replace_stats_inc(atomic64_t *stat_value)

{

	atomic64_inc(stat_value);

}



#endif

fs/btrfs/scrub.c

+4 −7
Original line number Diff line number Diff line
@@ -1124,7 +1124,7 @@ static int scrub_handle_errored_block(struct scrub_block *sblock_to_check) 


			if (scrub_write_page_to_dev_replace(sblock_other,

							    page_num) != 0) {

				btrfs_dev_replace_stats_inc(

				atomic64_inc(

					&fs_info->dev_replace.num_write_errors);

				success = 0;

			}
@@ -1564,8 +1564,7 @@ static int scrub_repair_page_from_good_copy(struct scrub_block *sblock_bad, 
		if (btrfsic_submit_bio_wait(bio)) {

			btrfs_dev_stat_inc_and_print(page_bad->dev,

				BTRFS_DEV_STAT_WRITE_ERRS);

			btrfs_dev_replace_stats_inc(

				&fs_info->dev_replace.num_write_errors);

			atomic64_inc(&fs_info->dev_replace.num_write_errors);

			bio_put(bio);

			return -EIO;

		}
@@ -1592,8 +1591,7 @@ static void scrub_write_block_to_dev_replace(struct scrub_block *sblock) 


		ret = scrub_write_page_to_dev_replace(sblock, page_num);

		if (ret)

			btrfs_dev_replace_stats_inc(

				&fs_info->dev_replace.num_write_errors);

			atomic64_inc(&fs_info->dev_replace.num_write_errors);

	}

}
@@ -1726,8 +1724,7 @@ static void scrub_wr_bio_end_io_worker(struct btrfs_work *work) 
			struct scrub_page *spage = sbio->pagev[i];



			spage->io_error = 1;

			btrfs_dev_replace_stats_inc(&dev_replace->

						    num_write_errors);

			atomic64_inc(&dev_replace->num_write_errors);

		}

	}