Commit e31a0e62 authored Oct 23, 2014 by Vaishali Thakkar Committed by Greg Kroah-Hartman Oct 27, 2014

Staging: vme: devices: Use kasprintf



This patch uses kasprintf which combines kmalloc and sprintf.
kasprintf also takes care of the size calculation.

This is done using Coccinelle. Semantic patch used is as follows:

@@
expression a,flag;
expression list args;
statement S;
@@

 a =
- \(kmalloc\|kzalloc\)(...,flag)
+ kasprintf (flag,args)
  <... when != a
  if (a == NULL || ...) S
  ...>
- sprintf(a,args);

Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent d2b77871

drivers/staging/vme/devices/vme_pio2_gpio.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -191,11 +191,11 @@ int pio2_gpio_init(struct pio2_card *card)
		int retval = 0;
		char *label;

		label = kmalloc(PIO2_NUM_CHANNELS, GFP_KERNEL);
		label = kasprintf(GFP_KERNEL,
		"%s@%s", driver_name, dev_name(&card->vdev->dev));
		if (label == NULL)
		return -ENOMEM;

		sprintf(label, "%s@%s", driver_name, dev_name(&card->vdev->dev));
		card->gc.label = label;

		card->gc.ngpio = PIO2_NUM_CHANNELS;