Commit dedf215b authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

staging: rtl8723bs: remove unused code 



There are two final hunks of code that are only built
if SDIO_DYNAMIC_ALLOC_MEM is defined however this is never
defined and if it was the code would lead to dereferencing
an uninitialized pointer oldmem.  It appears that a previous
commit 1babeb0c ("Staging: rtl8723bs: Remove dead code")
removed some of the dead code but not all of it. Clean this
up by removing the final hunks.

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d5469036

drivers/staging/rtl8723bs/hal/sdio_ops.c

+0 −10
Original line number Diff line number Diff line
@@ -428,9 +428,6 @@ static u32 sdio_read_port( 
	PSDIO_DATA psdio;

	struct hal_com_data *hal;

	u32 oldcnt;

#ifdef SDIO_DYNAMIC_ALLOC_MEM

	u8 *oldmem;

#endif

	s32 err;
@@ -447,13 +444,6 @@ static u32 sdio_read_port( 


	err = _sd_read(intfhdl, addr, cnt, mem);



#ifdef SDIO_DYNAMIC_ALLOC_MEM

	if ((oldcnt != cnt) && (oldmem)) {

		memcpy(oldmem, mem, oldcnt);

		kfree(mem);

	}

#endif



	if (err)

		return _FAIL;

	return _SUCCESS;