Commit d5cf467e authored by Markus Elfring's avatar Markus Elfring Committed by Mauro Carvalho Chehab
Browse files

[media] DaVinci-VPIF-Display: Use kcalloc() in vpif_probe() 



* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "kcalloc".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data type by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent c64d61df

drivers/media/platform/davinci/vpif_display.c

+1 −2
Original line number Diff line number Diff line
@@ -1274,8 +1274,7 @@ static __init int vpif_probe(struct platform_device *pdev) 
	vpif_obj.config = pdev->dev.platform_data;

	subdev_count = vpif_obj.config->subdev_count;

	subdevdata = vpif_obj.config->subdevinfo;

	vpif_obj.sd = kzalloc(sizeof(struct v4l2_subdev *) * subdev_count,

								GFP_KERNEL);

	vpif_obj.sd = kcalloc(subdev_count, sizeof(*vpif_obj.sd), GFP_KERNEL);

	if (vpif_obj.sd == NULL) {

		vpif_err("unable to allocate memory for subdevice pointers\n");

		err = -ENOMEM;