Commit d1a566be authored Jun 18, 2018 by Erik Stromdahl Committed by Kalle Valo Jun 28, 2018

ath10k: fix bug in masking of TID value



Although the TID mask is 0xf, the modulus operation does still not
produce identical results as the bitwise and operator. If the TID is 15, the
modulus operation will "convert" it to 0, whereas the bitwise and will keep it
as 15.

This was found during code review.

Signed-off-by: Erik Stromdahl <erik.stromdahl@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent 168f75f1

drivers/net/wireless/ath/ath10k/htt_tx.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1056,7 +1056,7 @@ static u8 ath10k_htt_tx_get_tid(struct sk_buff *skb, bool is_eth)
		if (!is_eth && ieee80211_is_mgmt(hdr->frame_control))
		return HTT_DATA_TX_EXT_TID_MGMT;
		else if (cb->flags & ATH10K_SKB_F_QOS)
		return skb->priority % IEEE80211_QOS_CTL_TID_MASK;
		return skb->priority & IEEE80211_QOS_CTL_TID_MASK;
		else
		return HTT_DATA_TX_EXT_TID_NON_QOS_MCAST_BCAST;
		}