Commit d14df339 authored by Dan Carpenter's avatar Dan Carpenter Committed by Takashi Iwai
Browse files

ALSA: hdsp - info leak in snd_hdsp_hwdep_ioctl() 



In GCC the sizeof(hdsp_version) is 8 because there is a 2 byte hole at
the end of the struct after ->firmware_rev.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent ac536a84

sound/pci/rme9652/hdsp.c

+1 −0
Original line number Diff line number Diff line
@@ -4845,6 +4845,7 @@ static int snd_hdsp_hwdep_ioctl(struct snd_hwdep *hw, struct file *file, unsigne 
			if ((err = hdsp_get_iobox_version(hdsp)) < 0)

				return err;

		}

		memset(&hdsp_version, 0, sizeof(hdsp_version));

		hdsp_version.io_type = hdsp->io_type;

		hdsp_version.firmware_rev = hdsp->firmware_rev;

		if ((err = copy_to_user(argp, &hdsp_version, sizeof(hdsp_version))))