Skip to content
Commit c29390c6 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

xps: must clear sender_cpu before forwarding



John reported that my previous commit added a regression
on his router.

This is because sender_cpu & napi_id share a common location,
so get_xps_queue() can see garbage and perform an out of bound access.

We need to make sure sender_cpu is cleared before doing the transmit,
otherwise any NIC busy poll enabled (skb_mark_napi_id()) can trigger
this bug.

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Reported-by: default avatarJohn <jw@nuclearfallout.net>
Bisected-by: default avatarJohn <jw@nuclearfallout.net>
Fixes: 2bd82484 ("xps: fix xps for stacked devices")
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c8a4d299
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment