Commit b3dd8957 authored by Tapasweni Pathak's avatar Tapasweni Pathak Committed by Greg Kroah-Hartman
Browse files

staging: lustre: lustre: llite: Use kstrdup 



Use kstrdup when the goal of an allocation is copy a string into the
allocated region.

Patch found by coccicheck.

Signed-off-by: default avatarTapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 438c5826

drivers/staging/lustre/lustre/llite/xattr_cache.c

+1 −4
Original line number Diff line number Diff line
@@ -126,9 +126,7 @@ static int ll_xattr_cache_add(struct list_head *cache, 
		return -ENOMEM;

	}



	xattr->xe_namelen = strlen(xattr_name) + 1;



	xattr->xe_name = kzalloc(xattr->xe_namelen, GFP_NOFS);

	xattr->xe_name = kstrdup(xattr_name, GFP_NOFS);

	if (!xattr->xe_name) {

		CDEBUG(D_CACHE, "failed to alloc xattr name %u\n",

		       xattr->xe_namelen);
@@ -141,7 +139,6 @@ static int ll_xattr_cache_add(struct list_head *cache, 
		goto err_value;

	}



	memcpy(xattr->xe_name, xattr_name, xattr->xe_namelen);

	memcpy(xattr->xe_value, xattr_val, xattr_val_len);

	xattr->xe_vallen = xattr_val_len;

	list_add(&xattr->xe_list, cache);